rmaz added a comment.
> What folks are thinking about writing less in METHOD_POOL?
I prefer the idea of it, but I think the `ReadMethodPoolVisitor` also has to be
changed for this to work. When it finds a selector in a module it will return
true, which causes the search to stop descending into dependent modules:
if (!Visitor(*CurrentModule))
continue;
// The visitor has requested that cut off visitation of any
// module that the current module depends on. To indicate this
// behavior, we mark all of the reachable modules as having been visited.
Wouldn't this logic have to be changed to ensure we pick up all the transitive
methods from dependent modules?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109632/new/
https://reviews.llvm.org/D109632
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
