pengfei added a comment. I'm wondering whether the test case is required or not for this patch. Reasons:
1. We have a test in llvm-test-suite can cover this and the test is just a snippet of it; 2. The test case can not reflect the direct effect of this change; 3. There're many variables in IR which may be easily affected by unrelated changes, which is annoying to others. What do you think? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110037/new/ https://reviews.llvm.org/D110037 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
