shafik added inline comments.
================
Comment at: clang/lib/AST/ASTImporter.cpp:711
+
+ /*template<typename T>
+ friend struct AttrArgImporter;
----------------
Looks like left over unused code?
================
Comment at: clang/lib/AST/ASTImporter.cpp:8448
+
+class AttrImporter {
+ Error Err = Error::success();
----------------
@martong the `ASTImporter` file is quite large as it is and I think it makes
sense to have `AttrImporter` but perhaps it would help long-term
maintainability to split it out into its own source file? What do you think?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109608/new/
https://reviews.llvm.org/D109608
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
