vsapsai added a comment.
Was looking at an issue caused by over-eager RedirectingFileSystem path
canonicalization and this patch fixes it. The repro we have is more complicated
(involves 3 modules), so I don't think it is worth including with this change.
================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:2006
ErrorOr<std::unique_ptr<File>>
RedirectingFileSystem::openFileForRead(const Twine &Path_) {
SmallString<256> Path;
----------------
dexonsmith wrote:
> I suggest giving this a real name if it's being used for anything. Maybe
> `PathAsWritten`?
Another idea is to keep this variable `Path` and rename old Path to
`CanonicalPath`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109128/new/
https://reviews.llvm.org/D109128
_______________________________________________
cfe-commits mailing list
[email protected]
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
