dexonsmith added reviewers: vsapsai, dexonsmith.
dexonsmith requested changes to this revision.
dexonsmith added a subscriber: vsapsai.
dexonsmith added a comment.
This revision now requires changes to proceed.
I think @vsapsai was looking at this as well.
This mostly LGTM, but I think this can be pretty easily unit tested. Please add
something to the tests in llvm/unittests/Support/VirtualFileSystemTest.cpp.
Also a nit inline.
================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:2006
ErrorOr<std::unique_ptr<File>>
RedirectingFileSystem::openFileForRead(const Twine &Path_) {
SmallString<256> Path;
----------------
I suggest giving this a real name if it's being used for anything. Maybe
`PathAsWritten`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109128/new/
https://reviews.llvm.org/D109128
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
