kito-cheng marked an inline comment as done. kito-cheng added inline comments.
================ Comment at: llvm/lib/Support/RISCVISAInfo.cpp:268 +// omitted from the version string. E.g., rv32i2p0, rv32i2, rv32i2p1. +static Error getExtensionVersion(StringRef MArch, StringRef Ext, StringRef In, + unsigned &Major, unsigned &Minor, ---------------- eopXD wrote: > For naming consistency with `parseArchString`, maybe rename `MArch` to `Arch`? It turns out the argument isn't used anywhere...so I remove that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105168/new/ https://reviews.llvm.org/D105168 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
