owenpan added inline comments.
================ Comment at: clang/lib/Format/TokenAnnotator.cpp:3788-3790 + if (Line.First && Line.First->Next && + Line.First->isOneOf(Keywords.kw_internal, tok::kw_public, + tok::kw_private, tok::kw_protected) && ---------------- Nit: can you add a boolean above the outer `if` so that it can be used in the `if` below? Also, `Line.First` is inconsistent with `Line.startsWith` elsewhere? I think the latter skips leading comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108810/new/ https://reviews.llvm.org/D108810 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
