krasimir accepted this revision.
krasimir added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Format/TokenAnnotator.cpp:3803
+      if (Line.startsWith(Keywords.kw_interface) &&
+          Style.BraceWrapping.AfterClass)
+        return true;
----------------
nit: the `&& Style.BraceWrapping.AfterClass` is unnecessary since we've ensured 
that in the parent `if`. I'd just fold the `kw_interface` case into the 
previous `if`, and then it seems we can further fold the remaining inner `if` 
into the parent `if`, resulting in this whole section (lines 3796--3805) 
turning into a single large `if` statement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108810/new/

https://reviews.llvm.org/D108810

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to