owenpan added a comment.

In D108752#2967040 <https://reviews.llvm.org/D108752#2967040>, @MyDeveloperDay 
wrote:

> This looks good, I like to move towards one style, it was getting too 
> confusing.

I agree!

> Did you test this on a large code base at all?

No. I don't think it's necessary (as this patch doesn't impact breaking 
constructor initializers except perhaps for the new value `Never`, which is 
already covered by the new test cases) but will try.

> I'll pull the patch to my local source and see if it makes any changes, but 
> to be honest we only use the `BreakConstructorInitializersBeforeComma` option

Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108752/new/

https://reviews.llvm.org/D108752

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to