owenpan added inline comments.
================ Comment at: clang/lib/Format/Format.cpp:1189 GoogleStyle.DerivePointerAlignment = true; + GoogleStyle.PackConstructorInitializers = FormatStyle::PCIS_NextLine; GoogleStyle.IncludeStyle.IncludeCategories = {{"^<ext/.*\\.h>", 2, 0, false}, ---------------- Need to move this line down to keep the options sorted. ================ Comment at: clang/unittests/Format/FormatTest.cpp:18463-18471 + Style.PackConstructorInitializers = FormatStyle::PCIS_Never; + CHECK_PARSE("PackConstructorInitializers: BinPack", + PackConstructorInitializers, FormatStyle::PCIS_BinPack); + CHECK_PARSE("PackConstructorInitializers: CurrentLine", + PackConstructorInitializers, FormatStyle::PCIS_CurrentLine); + CHECK_PARSE("PackConstructorInitializers: NextLine", + PackConstructorInitializers, FormatStyle::PCIS_NextLine); ---------------- Will use the default `PCIS_BinPack` as the initial value and move the last `CHECK_PARSE` to the top. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108752/new/ https://reviews.llvm.org/D108752 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits