bcain added a comment.

In D108083#2947907 <https://reviews.llvm.org/D108083#2947907>, @vitalybuka 
wrote:

> Can you cut this into separate peaces, at least patch per sanitizer for "asan 
> lsan ubsan scudo scudo_standalone cfi safestack"?

Sure, that's no problem. While I'm breaking it up, us there a 
guideline/preference to whether the clang changes can be combined in one of 
these patches, or should those be on their own as well?

> Some common peaces could be probably extracted as well.





================
Comment at: compiler-rt/test/asan/CMakeLists.txt:19
     set(${bits} 64)
-  elseif (${arch} MATCHES "i386|arm|mips|mipsel|sparc")
+  elseif (${arch} MATCHES "i386|arm|mips|mipsel|sparc|hexagon")
     set(${bits} 32)
----------------
vitalybuka wrote:
> why only this test changes?
> 
Sorry, I shouldnt have included this, I'll omit it. I'd like to land the build 
changes before test ones. 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108083/new/

https://reviews.llvm.org/D108083

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to