vitalybuka added a comment.
Can you cut this into separate peaces, at least patch per sanitizer for "asan
lsan ubsan scudo scudo_standalone cfi safestack"?
Some common peaces could be probably extracted as well.
================
Comment at:
compiler-rt/lib/sanitizer_common/sanitizer_platform_limits_posix.h:106
+#elif defined(__hexagon__)
+const unsigned struct_kernel_stat_sz = 128;
+const unsigned struct_kernel_stat64_sz = 0;
----------------
please clang-format entire patch
================
Comment at:
compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:130
+ } else {
+ return false;
+ }
----------------
Please fix clang-tidy which can be fixed.
================
Comment at: compiler-rt/test/asan/CMakeLists.txt:19
set(${bits} 64)
- elseif (${arch} MATCHES "i386|arm|mips|mipsel|sparc")
+ elseif (${arch} MATCHES "i386|arm|mips|mipsel|sparc|hexagon")
set(${bits} 32)
----------------
why only this test changes?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D108083/new/
https://reviews.llvm.org/D108083
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
