aaron.ballman added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6846-6847
+ return;
+ if (hasBTFTagAttr(D, Str))
+ return;
+
----------------
This should diagnose that the attribute is being ignored due to the mismatch in
tags (and probably have a note to the previous declaration as well so users can
see both sides of the conflict).
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:6853-6854
+BTFTagAttr *Sema::mergeBTFTagAttr(Decl *D, const BTFTagAttr &AL) {
+ if (hasBTFTagAttr(D, AL.getBTFTag()))
+ return nullptr;
+ return ::new (Context) BTFTagAttr(Context, AL, AL.getBTFTag());
----------------
This should diagnose as well when ignoring the attribute.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D106614/new/
https://reviews.llvm.org/D106614
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
