aaron.ballman added a comment. In D106614#2912292 <https://reviews.llvm.org/D106614#2912292>, @yonghong-song wrote:
>> This currently has no codegen, so it only adds the attribute to the AST and >> does nothing with it. Can you also add the codegen components to this patch? > > In one of my early PIC patches, David Blaikie suggested to break into > manageable pieces > for review and that is why I have multiple patches instead of one giant one. > Please let > me know if you have better suggestions. Ah, nope, this is fine -- I had missed noticing that this was part of a patch stack. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106614/new/ https://reviews.llvm.org/D106614 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
