kbobyrev added a comment.

Hi! Thanks for the patch, it makes sense to me! Honestly, I think having the 
`open` shadow is maybe not the best way to solve this (please feel free to let 
me know if there are reasons it would be better), maybe spell it out explicitly 
(there aren't that many cases of `open`)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106792/new/

https://reviews.llvm.org/D106792

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to