ABataev added inline comments.
================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6348-6352
+ } else if(HaveNowaitClause == true) {
+ assert("Nowait clause is used separately in OMPInteropDirective.");
} else {
- llvm_unreachable("Missing Interop clauses.");
+ assert("Unhandled or missing clause for OMPInteropDirective ");
}
----------------
Could you merge these asserts and put them as preconditions for the `if-else`
chain somehow?
================
Comment at: clang/test/OpenMP/interop_irbuilder.cpp:1
+// RUN: %clang_cc1 -verify -fopenmp -o - %s
+
----------------
ABataev wrote:
> Actual codegen checks are missing
Still no checks, need to add `| FileCheck %s` to the `RUN` line
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105876/new/
https://reviews.llvm.org/D105876
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
