aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
In D106577#2897450 <https://reviews.llvm.org/D106577#2897450>, @cor3ntin wrote: > In D106577#2897312 <https://reviews.llvm.org/D106577#2897312>, @aaron.ballman > wrote: > >> Can you also add a test that explicitly uses `-fshort-wchar` to verify that >> we don't predefine the macro? > > There is one already! (init.c L288) Oh, thank you for pointing that out! LGTM! ================ Comment at: clang/lib/Frontend/InitPreprocessor.cpp:430-435 + // Because Clang only supports UTF-32 or UTF-16 as the + // wide execution encoding, any platform that doesn't uses + // short wchar can represent the entire Unicode code space + // Unicode 13 was released in December 2020. + // Note that new Unicode version are *very* unlikely to affect + // representability ---------------- cor3ntin wrote: > aaron.ballman wrote: > > Are we going to have to remember to update this value each time Unicode > > updates? > No. But I don't think it's matter, as long as it is defined, GCC hasn't > updated since 2017 Okay, I don't mind updating the value when it becomes a problem someone notices. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106577/new/ https://reviews.llvm.org/D106577 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
