aaron.ballman added a comment. In http://reviews.llvm.org/D20428#434238, @alexfh wrote:
> Full context diff, please. Pardon my complete ignorance, but how? I generated the diff from svn the usual way, so I assume I've missed some step. > > I'm not certain of the best way to test this functionality in isolation; > > > Same way other locations/ranges are tested in > unittests/AST/SourceLocationTest.cpp? Ah, good point, we have unit tests for this sort of thing. I'll add some unit tests and generate a new patch. Thanks! http://reviews.llvm.org/D20428 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits