cor3ntin added a comment. In D105127#2850975 <https://reviews.llvm.org/D105127#2850975>, @mizvekov wrote:
> So I read the paper, downloaded this patch, played around with it a little > bit, tried some different tests, like expressions with dependent types, > classes with regular/explicit user-defined conversions, function names and > some other examples that are mentioned in the paper. > It works fine on these. > > However, I confirm that the failures in `CXX/except/except.spec/p1.cpp` > detected by the buildbots are real. > It fails for me with this DR, works on parent revision. Yep, I need to look at that. I've ran the entire test suite locally without issue initially but maybe I broke something! In D105127#2851049 <https://reviews.llvm.org/D105127#2851049>, @mizvekov wrote: > Its unfortunate the buildbot does not have debug symbols. > > If you have not managed to reproduce it locally, here is the backtrace I got: Thanks. I think my local build had `NDEBUG` defined, so an assert was not firing My current guess is that early exiting on value-dependent expressions bypasses check expected down the line, so I'll confirm that, fix it and update the PR! Thanks for your help! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105127/new/ https://reviews.llvm.org/D105127 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
