nickdesaulniers requested changes to this revision. nickdesaulniers added inline comments. This revision now requires changes to proceed.
================ Comment at: clang/test/Driver/aarch64-target-as-march.s:29 +// RUN: FileCheck --check-prefix=MULTIPLE-VALUES %s + +// MULTIPLE-VALUES: "-target-feature" "+v8.1a ---------------- jcai19 wrote: > DavidSpickett wrote: > > Add a test with `-Wa,-march=armv8.2-a,-march=armv8.1-a` (one -Wa with > > multiple values attached), then repeat the two tests but with `-Xassembler` > > instead. > I added a test case for -Xassembler -march=armv8.2-a,-march=armv8.1-a, but > it seems it does not support multiple values in one invocation? > > clang --target=aarch64-linux-gnueabi -Xassembler > -march=armv8.2-a,-march=armv8.1-a -c foo.s -o ias.o -### > ... > clang-13: error: the clang compiler does not support '-Xassembler > -march=armv8.2-a,-march=armv8.1-a' > ... I don't think @DavidSpickett meant more `UNUSED-WARNING` tests, but tests that check the actual chosen value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
