DavidSpickett accepted this revision. DavidSpickett added a comment. > LGTM; any additional thoughts @DavidSpickett ?
A couple of additional tests just to be safe but otherwise LGTM. ================ Comment at: clang/test/Driver/aarch64-target-as-march.s:29 +// RUN: FileCheck --check-prefix=MULTIPLE-VALUES %s + +// MULTIPLE-VALUES: "-target-feature" "+v8.1a ---------------- Add a test with `-Wa,-march=armv8.2-a,-march=armv8.1-a` (one -Wa with multiple values attached), then repeat the two tests but with `-Xassembler` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103184/new/ https://reviews.llvm.org/D103184 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
