urnathan marked 2 inline comments as done. urnathan added inline comments.
================ Comment at: clang/include/clang/AST/DeclCXX.h:3390 ConstructorUsingShadowDecl(ASTContext &C, DeclContext *DC, SourceLocation Loc, - UsingDecl *Using, NamedDecl *Target, + BaseUsingDecl *Using, NamedDecl *Target, bool TargetInVirtualBase) ---------------- davrec wrote: > `BaseUsingDecl` here should remain `UsingDecl`. > Additionally, I would add a `UsingDecl *getIntroducer() { return > cast<UsingDecl>(UsingShadowDecl::getIntroducer()); }` method here. Done, this required a further reordering of class definitions, so that UsingDecl is complete at this point. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits