urnathan added inline comments.
================ Comment at: clang/lib/AST/ASTImporter.cpp:4623 - Expected<UsingDecl *> ToUsingOrErr = import(D->getUsingDecl()); - if (!ToUsingOrErr) - return ToUsingOrErr.takeError(); + Expected<BaseUsingDecl *> ToIntroducerOrErr = import(D->getIntroducer()); + if (!ToIntroducerOrErr) ---------------- shafik wrote: > urnathan wrote: > > shafik wrote: > > > It would nice to expand upon the `ImportUsingShadowDecl` in > > > `ASTImporterTest.cpp` as we expand this change to make sure the > > > ASTImporter is importing all the cases correctly. Right now we just have > > > a very basic test there. > > Please clarify what you are requiring of this patch series. What you > > describe sounds like an orthogonal desire. > Sure, happy to clarify. As the functionality is complete, tests should be > added to verify that the `ASTImporter` correctly deals with the new > functionality but it would be nice as we add that new test to also expand the > tests further but that would be optional but probably not too much more work. I've added unit tests for UsingEnumDecl into patch 4, and extended the UsingDecl tests a bit further CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101777/new/ https://reviews.llvm.org/D101777 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
