bruno accepted this revision.
bruno added a comment.
This revision is now accepted and ready to land.
LGTM. An additional review here would be nice though.
> good, it appears the patch bot fail is fixed -- it seems unhappy with
> non-tree-like dependency graphs, and tries to apply each reachable patch as
> many times as it is reachable :(
> The data race failure seems entirely unconnected with this patch -- please
> correct me if I'm wrong.
Indeed!
================
Comment at: clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp:20
class C {
+public:
int g();
----------------
urnathan wrote:
> bruno wrote:
> > bruno wrote:
> > > > The change to
> > > > clang/test/CXX/dcl.dcl/basic.namespace/namespace.udecl/p3.cpp is to
> > > > silence an uninteresting access error that the above change causes.
> > >
> > > The fact that the access check changed for previous version of the
> > > language (not necessarily related to p1099) indicates that this specific
> > > change deserves its own patch.
> > How about this one?
> I didn;t describe this very well. What happens with the reordering of the
> checks of the named scopes is that we now diagnose that C::g is private and
> then that we're reaching into a struct. Before we just diagnosed the second
> problem and bailed, never getting to the first. The test is aiming to
> discover that second problem is detected, and doesn't care about the access.
> Hence make it public.
Oh I see, makes sense. Thanks for the explanation.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D100276/new/
https://reviews.llvm.org/D100276
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
