steakhal added a comment.

There are quite a few places where the extdef mappings should be updated.
For discovering them I suggest you asserting the new file format (only for 
detecting them!). This way if you miss one, it wouldn't silently 'work' 
somehow, but raise your attention.

There are a few references to the format of this mapping in the 
`clang/docs/analyzer/user-docs/CrossTranslationUnit.rst` and probably in other 
files.
Those should be updated to match the new format.

I'm sorry for burdening you with all of this, but I think this is the way to 
make this parsing more robust. I really appreciate your work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102669/new/

https://reviews.llvm.org/D102669

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to