martong added a comment.

First of all, thank you for the patch!

We had a meeting with my colleges (@steakhal, @gamesh411) and we agreed in the 
following. This issue you are trying to solve here is indeed a serious problem, 
but we'd like to suggest an alternative and perhaps more durable solution. In 
`CrossTranslationUnitContext::getLookupName(const NamedDecl *ND)` it would be 
possible to extend the returned string with a prefix that encodes the length of 
the USR string.
So, instead of

  c:@F@g#I# ctu-other.cpp.ast

we'd get

  9:c:@F@g#I# ctu-other.cpp.ast

This way, we could handle even file names with spaces in them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102669/new/

https://reviews.llvm.org/D102669

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to