etienneb added a comment. In http://reviews.llvm.org/D20180#427893, @rnk wrote:
> In http://reviews.llvm.org/D20180#427840, @alexfh wrote: > > > `inline` seems to be completely redundant here. Can you try removing it and > > running whatever build configurations were failing without > > http://reviews.llvm.org/D20182? > > > My bad, it's explicit function template specializations that need to be > marked inline when in headers. Hmm, it's my bad! I tried it to solve broken bot. I try it that way because it is implemented with "inline" in ASTMatcherInternal: Example: template <> inline const Stmt *GetBodyMatcher<FunctionDecl>::get(const FunctionDecl &Node) { return Node.doesThisDeclarationHaveABody() ? Node.getBody() : nullptr; } But, it's "explicit template specialisation" in the above case. Revert patch is ready: http://reviews.llvm.org/D20189 Still thanks Reid for helping finding the repro case. Repository: rL LLVM http://reviews.llvm.org/D20180 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
