delcypher marked an inline comment as done.
delcypher added inline comments.
================
Comment at: clang/lib/Driver/ToolChain.cpp:408
default:
return getOS();
}
----------------
arphaman wrote:
> It might be cleaner to do a check for `isOSDarwin` here, as that will help
> with any other Darwin platforms that we need to support.
@arphaman That seems like a good idea. I didn't know this API existed. I'll try
to switch to that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101682/new/
https://reviews.llvm.org/D101682
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
