arphaman accepted this revision.
arphaman added a comment.
This revision is now accepted and ready to land.
LGTM, the only suggestion I have is below.
================
Comment at: clang/lib/Driver/ToolChain.cpp:408
default:
return getOS();
}
----------------
It might be cleaner to do a check for `isOSDarwin` here, as that will help with
any other Darwin platforms that we need to support.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101682/new/
https://reviews.llvm.org/D101682
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
