xbolva00 added inline comments.
================ Comment at: clang/include/clang/Basic/DiagnosticDriverKinds.td:280 +def err_drv_small_columns : Error< + "invalid value '%1' in '%0', expected '%1' to be '%2' or greater">; ---------------- nickdesaulniers wrote: > xbolva00 wrote: > > nickdesaulniers wrote: > > > xbolva00 wrote: > > > > invalid value '%1' in '%0', value must be '%2' or greater > > > > > > > > ? > > > > > > > > Current wording sounds strange imho. > > > I don't care what color we paint the bikeshed, but please suggest a color > > > if you don't like the one I've chosen. > > ? > > > > I suggested. > I'm sorry; I don't know how I misread what you said. No problem, thanks :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101387/new/ https://reviews.llvm.org/D101387 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
