rsmith added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3115
D.Diag(diag::err_drv_invalid_value_with_suggestion)
- << A->getOption().getName() << Value
- << "valid arguments to '-mstack-protector-guard=' are:tls global";
+ << A->getOption().getName() << Value << " tls global";
return;
----------------
I think there should be no leading space here; there's already a space in the
format string. (By default `FileCheck` ignores differences in amount of
whitespace which I imagine is why the test is passing. I think
`-strict-whitespace` would catch this.)
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:3141
D.Diag(diag::err_drv_invalid_value_with_suggestion)
- << A->getOption().getName() << Value
- << "for X86, valid arguments to '-mstack-protector-guard-reg=' are:fs
gs";
+ << A->getOption().getName() << Value << " fs gs";
return;
----------------
Likewise here.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101387/new/
https://reviews.llvm.org/D101387
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
