Mordante added a comment.

In D100705#2696708 <https://reviews.llvm.org/D100705#2696708>, @xgupta wrote:

> Nice work @jnyfah!
>
> @Mordante Review is already accepted by @curdeius in 
> https://reviews.llvm.org/D100696. And actually, I see your message after 
> committing the patch.

In general when a patch is blocked by a reviewer it shouldn't be committed. 
However the patch is trivial so not a big issue.
Secondly, if I'd known @curdeius approved it I would have approved as libc++.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D100705/new/

https://reviews.llvm.org/D100705

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to