This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG21bef4e11e48: [NFC] Fixed Typos (authored by jnyfah, committed by xgupta).
Changed prior to commit: https://reviews.llvm.org/D100705?vs=338309&id=338317#toc Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100705/new/ https://reviews.llvm.org/D100705 Files: clang/docs/UsersManual.rst libcxx/docs/UsingLibcxx.rst Index: libcxx/docs/UsingLibcxx.rst =================================================================== --- libcxx/docs/UsingLibcxx.rst +++ libcxx/docs/UsingLibcxx.rst @@ -114,10 +114,10 @@ GCC does not provide a way to switch from libstdc++ to libc++. You must manually configure the compile and link commands. -In particular you must tell GCC to remove the libstdc++ include directories +In particular, you must tell GCC to remove the libstdc++ include directories using ``-nostdinc++`` and to not link libstdc++.so using ``-nodefaultlibs``. -Note that ``-nodefaultlibs`` removes all of the standard system libraries and +Note that ``-nodefaultlibs`` removes all the standard system libraries and not just libstdc++ so they must be manually linked. For example: .. code-block:: bash @@ -151,7 +151,7 @@ **_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS**: This macro is used to enable -Wthread-safety annotations on libc++'s - ``std::mutex`` and ``std::lock_guard``. By default these annotations are + ``std::mutex`` and ``std::lock_guard``. By default, these annotations are disabled and must be manually enabled by the user. **_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS**: Index: clang/docs/UsersManual.rst =================================================================== --- clang/docs/UsersManual.rst +++ clang/docs/UsersManual.rst @@ -686,7 +686,7 @@ .. option:: -gen-reproducer Generates preprocessed source files, a reproducer script and if relevant, a - cache containing: built module pcm's and all headers needed to rebuilt the + cache containing: built module pcm's and all headers needed to rebuild the same modules. .. _rpass:
Index: libcxx/docs/UsingLibcxx.rst =================================================================== --- libcxx/docs/UsingLibcxx.rst +++ libcxx/docs/UsingLibcxx.rst @@ -114,10 +114,10 @@ GCC does not provide a way to switch from libstdc++ to libc++. You must manually configure the compile and link commands. -In particular you must tell GCC to remove the libstdc++ include directories +In particular, you must tell GCC to remove the libstdc++ include directories using ``-nostdinc++`` and to not link libstdc++.so using ``-nodefaultlibs``. -Note that ``-nodefaultlibs`` removes all of the standard system libraries and +Note that ``-nodefaultlibs`` removes all the standard system libraries and not just libstdc++ so they must be manually linked. For example: .. code-block:: bash @@ -151,7 +151,7 @@ **_LIBCPP_ENABLE_THREAD_SAFETY_ANNOTATIONS**: This macro is used to enable -Wthread-safety annotations on libc++'s - ``std::mutex`` and ``std::lock_guard``. By default these annotations are + ``std::mutex`` and ``std::lock_guard``. By default, these annotations are disabled and must be manually enabled by the user. **_LIBCPP_DISABLE_VISIBILITY_ANNOTATIONS**: Index: clang/docs/UsersManual.rst =================================================================== --- clang/docs/UsersManual.rst +++ clang/docs/UsersManual.rst @@ -686,7 +686,7 @@ .. option:: -gen-reproducer Generates preprocessed source files, a reproducer script and if relevant, a - cache containing: built module pcm's and all headers needed to rebuilt the + cache containing: built module pcm's and all headers needed to rebuild the same modules. .. _rpass:
_______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
