michael_miller added inline comments.
================
Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:31
@@ +30,3 @@
+// Convenience utility to get a RecordDecl from a QualType.
+const RecordDecl *getCanonicalRecordDecl(const QualType &Type) {
+ if (const auto *RT = Type.getCanonicalType()->getAs<RecordType>())
----------------
alexfh wrote:
> Is `getCanonicalType()` important here? Did you try using
> `QualType::getAsCXXRecordDecl()`?
Probably not but I didn't try it. I just moved the previous function up to the
top so I didn't have to forward declare it.
One thing I'm simply unsure of is whether it's possible to get a RecordDecl
that's not a CXXRecordDecl in C++ code. It seems like the answer is no but that
might be another reason to keep it as is if I'm wrong about that...
http://reviews.llvm.org/D19993
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
