steakhal added a comment. Some minor logical issues inline.
================ Comment at: clang/lib/StaticAnalyzer/Core/BugReporterVisitors.cpp:1944-1945 + return; + if (!BO->isMultiplicativeOp()) + return; + ---------------- There are only 3 multiplicative operators: ``` BINARY_OPERATION(Mul, "*") BINARY_OPERATION(Div, "/") BINARY_OPERATION(Rem, "%") ``` So, the opcode can never be `BO_MulAssign` later. The comment for the else block is also inaccurate for the same reason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99344/new/ https://reviews.llvm.org/D99344 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
