ruiling added a comment.

>> Sounds we still need a long way to get there? Do we think the patch 
>> acceptable as a short-term solution?
>
> Guess it's a tradeoff. Doesn't look like a load of code/complexity. - but 
> equally, does it provide much value? Or is it enough to know it can 
> eventually be addressed in a more general manner?

I don't have an answer for the second question, but this change would make 
later pass like `ScalarEvolution` can know the two pointers from the same 
integer by `inttoptr` are identical. Then we can merge possible consecutive 
memory access based on such pointers, we observed about 2% overall performance 
improvement for a critical workload.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99121/new/

https://reviews.llvm.org/D99121

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to