vsavchenko added a comment.

In D86465#2640687 <https://reviews.llvm.org/D86465#2640687>, @steakhal wrote:

> Given that it did not change any reports in our testbench it seems to be safe 
> to land it.
>
> It clearly improves the API significantly, so I'm not opposing.
> Really good work @vsavchenko.

Thanks 😊

> PS: If should support `_ExtInt`s as well, even if they are not too common.
> Please try to fill this gap, before you push your changes.

I do have a bit of a struggle here.  This is a unit-test and thus should be 
compiled for all supported architecture by all of the supported compilers.
Is there a `__has_feature` or something for me to check if `_ExtInt` can be 
used?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D86465/new/

https://reviews.llvm.org/D86465

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to