steakhal added a comment. Ah, I wanted to give it a go, but the bots caught an assertion failure for the parent revision of this. See the details at the Bugzilla ticket <https://bugs.llvm.org/show_bug.cgi?id=49642>.
What is more concerning is that this patch resolves that assertion failure. I guess it implies it can not be NFC? Regardless, I'm gonna wait to get that issue fixed before I have a deeper look. ================ Comment at: clang/unittests/StaticAnalyzer/RangeSetTest.cpp:191 +using IntTypes = ::testing::Types<int8_t, uint8_t, int16_t, uint16_t, int32_t, + uint32_t, int64_t, uint64_t>; +TYPED_TEST_CASE(RangeSetTest, IntTypes); ---------------- You should probably test `_ExtInt`s as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D86465/new/ https://reviews.llvm.org/D86465 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
