njames93 requested changes to this revision.
njames93 added inline comments.
This revision now requires changes to proceed.
================
Comment at: clang/include/clang/ASTMatchers/ASTMatchers.h:3812-3821
AST_POLYMORPHIC_MATCHER_P_OVERLOAD(
hasType,
AST_POLYMORPHIC_SUPPORTED_TYPES(Expr, FriendDecl, TypedefNameDecl,
- ValueDecl),
+ ValueDecl, CXXBaseSpecifier),
internal::Matcher<QualType>, InnerMatcher, 0) {
QualType QT = internal::getUnderlyingType(Node);
if (!QT.isNull())
----------------
I don't think the change to this matcher is warranted.
The `hasType` matcher that accepts a DeclarationMatcher already has support for
cxxBaseSpecifier.
However overloading the matcher that takes a QualType matcher doesn't make
sense as base specifiers have no qualifications.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69218/new/
https://reviews.llvm.org/D69218
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
