aaron.ballman added inline comments.
================
Comment at: clang/lib/ASTMatchers/Dynamic/Registry.cpp:182
REGISTER_MATCHER(cxxConversionDecl);
+ REGISTER_MATCHER(cxxBaseSpecifier);
REGISTER_MATCHER(cxxCtorInitializer);
----------------
Please keep this list sorted alphabetically.
================
Comment at: clang/unittests/ASTMatchers/ASTMatchersTraversalTest.cpp:329
+ EXPECT_TRUE(matches("class X {}; class Y : X {};", ClassHasBaseClassX));
+ EXPECT_TRUE(notMatches("class Z {}; class Y : Z {};", ClassHasBaseClassX));
+}
----------------
I'd like to see another test along these lines:
```
struct Base {};
struct Intermediate : Base {};
struct Derived : Intermediate {};
```
Where we test that `Derived` does not have a direct base relationship with
`Base`, but does with `hasAnyBase`.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69218/new/
https://reviews.llvm.org/D69218
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
