zero9178 marked an inline comment as done. zero9178 added inline comments.
================ Comment at: llvm/cmake/modules/GetErrcMessages.cmake:3-6 +# The purpose of this function is to supply those error messages to llvm-lit using the errc_messages config +# Currently supplied and needed error codes: ENOENT, EISDIR, EINVAL and EACCES +# Messages are semi colon separated +# Keep amount, order and tested error codes in sync with llvm/utils/lit/lit/llvm/config.py ---------------- jhenderson wrote: > Each of these lines look like they need a trailing full stop added. Just to double check, that means adding a `.` at the end of the lines right? ================ Comment at: llvm/utils/lit/lit/llvm/config.py:14 lit_path_displayed = False +python_errc_displayed = False ---------------- jhenderson wrote: > Seems like this variable is unused and got leftover from an experiment at > some point? Correct, that was accidently left in. I immediately followed up with a commit removing it here: https://reviews.llvm.org/rG68e4084bf68ae7517491a6a0cbfd6d3b6f93cef7 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98278/new/ https://reviews.llvm.org/D98278 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
