jhenderson added a comment. Thanks for working on this. A couple of post-commit comments to look at, otherwise looks good. Thanks for figuring out how to do this in a portable manner!
================ Comment at: llvm/cmake/modules/GetErrcMessages.cmake:1 + +# This function returns the messages of various POSIX error codes as they are returned by std::error_code. ---------------- Delete this blank line? ================ Comment at: llvm/cmake/modules/GetErrcMessages.cmake:3-6 +# The purpose of this function is to supply those error messages to llvm-lit using the errc_messages config +# Currently supplied and needed error codes: ENOENT, EISDIR, EINVAL and EACCES +# Messages are semi colon separated +# Keep amount, order and tested error codes in sync with llvm/utils/lit/lit/llvm/config.py ---------------- Each of these lines look like they need a trailing full stop added. ================ Comment at: llvm/utils/lit/lit/llvm/config.py:14 lit_path_displayed = False +python_errc_displayed = False ---------------- Seems like this variable is unused and got leftover from an experiment at some point? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98278/new/ https://reviews.llvm.org/D98278 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
