hubert.reinterpretcast added inline comments.
================
Comment at: clang/include/clang/Driver/Driver.h:160
/// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled.
- const char *CCPrintStatReportFilename;
+ std::string CCPrintStatReportFilename;
----------------
I'm seeing code left unchanged like:
```
TheDriver.CCPrintOptionsFilename = ::getenv("CC_PRINT_OPTIONS_FILE");
```
Assigning to a `std::string` from a null `char *` is known to cause things like
```
Segmentation fault
```
================
Comment at: clang/lib/Driver/Compilation.cpp:173
// output stream.
- if (getDriver().CCPrintOptions && getDriver().CCPrintOptionsFilename) {
+ if (getDriver().CCPrintOptions &&
!getDriver().CCPrintOptionsFilename.empty()) {
std::error_code EC;
----------------
Please update for the clang-format suggestions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98554/new/
https://reviews.llvm.org/D98554
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
