SeanP marked 2 inline comments as done.
SeanP added inline comments.
================
Comment at: clang/include/clang/Driver/Driver.h:160
/// The file to log CC_PRINT_PROC_STAT_FILE output to, if enabled.
- const char *CCPrintStatReportFilename;
+ std::string CCPrintStatReportFilename;
----------------
hubert.reinterpretcast wrote:
> I'm seeing code left unchanged like:
> ```
> TheDriver.CCPrintOptionsFilename = ::getenv("CC_PRINT_OPTIONS_FILE");
> ```
>
> Assigning to a `std::string` from a null `char *` is known to cause things
> like
> ```
> Segmentation fault
> ```
>
I've fixed in newest patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98554/new/
https://reviews.llvm.org/D98554
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
