MaskRay added a comment.

If the end goal is to provide a complete libc, and currently the usage is 
expected to shadow system libc (this has to be very careful, as I don't know 
how shadowing some important components like pthread shall work), perhaps the 
name should convey this point?



================
Comment at: clang/test/Driver/linux-ld.c:235
 // CHECK-CLANG-LD-STATIC-PIE-NOPIE: error: cannot specify 'nopie' along with 
'static-pie'
 //
+// RUN: %clang -experimental-link-llvmlibc -no-canonical-prefixes %s -### -o 
%t.o 2>&1 \
----------------
Empty `// ` actually makes browsing difficult and we generally don't do this 
for other tests. You can omit them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97736/new/

https://reviews.llvm.org/D97736

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to