jsji added inline comments.

================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:405
+      T.getOSVersion(major, minor, micro);
+      TargetCPUName = major == 7 && minor < 2 ? "pwr4" : "pwr7";
+    } else if (T.getArch() == llvm::Triple::ppc64le)
----------------
jsji wrote:
> Please add comments here about AIX 7.2's minimal arch is P7.
`major == 7 ` should this be `major <= 7 `? Or else, we may get `pwr7` for AIX 
5.1.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97823/new/

https://reviews.llvm.org/D97823

_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to