aganea accepted this revision. aganea added a comment. This revision is now accepted and ready to land.
LGTM, just a few minor things: ================ Comment at: clang/docs/UsersManual.rst:798 + Setting ``CC_PRINT_PROC_STAT`` to ``1`` enables the feature, the report goes to + the stdout in the human readable format. + Setting ``CC_PRINT_PROC_STAT_FILE`` to a fully qualified file path makes it report ---------------- "enables the feature, the report goes to ~~the~~ stdout in ~~the~~ human readable format." ================ Comment at: clang/docs/UsersManual.rst:800 + Setting ``CC_PRINT_PROC_STAT_FILE`` to a fully qualified file path makes it report + the process statistics to the given file in the CSV format. Specifying a relative + path will likely lead to multiple files with the same name created in different ---------------- "~~the~~ process statistics to the given file in the CSV format" ================ Comment at: clang/docs/UsersManual.rst:804 + + These environment variables are handy when you need to request the statistics + report without changing your build scripts or alter the existing set of compiler ---------------- Would you be able to merge this paragraph with the following one please? It could be something like: "These environment variables are handy when you need to request the statistics report without changing your build scripts or alter the existing set of compiler options. Note that `-fproc-stat-report` take precedence over `CC_PRINT_PROC_STAT` and `CC_PRINT_PROC_STAT_FILE`." Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97094/new/ https://reviews.llvm.org/D97094 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
