glaubitz added inline comments.
================ Comment at: clang/test/Driver/m68k-sub-archs.cpp:1 +// RUN: %clang -### -target m68k-unknown-linux -mcpu=68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s +// RUN: %clang -### -target m68k-unknown-linux -mcpu=m68000 %s 2>&1 | FileCheck --check-prefix=CHECK-MX00 %s ---------------- jrtc27 wrote: > glaubitz wrote: > > jrtc27 wrote: > > > jrtc27 wrote: > > > > Why MX00 etc? > > > I think you misunderstood my comment. Having CHECK-A, CHECK-B, CHECK-C > > > etc is fine. My issue was with the MX00/MX10/MX20 suffix that makes no > > > sense to me; it's M68000/M68010/etc, X normally stands for a variable, > > > but the 0 is always constant. M00/M10/etc, M000/M010/etc and > > > M68000/M68010/M68020 would seem like more sensible names (also without > > > the M would be fine), but MX00 looks like it's trying to match > > > M000/M100/M200/etc, which is not the case. > > From what I can see, I would say it's supposed to represent the "680" in > > "M68020", for example. > Yeah, I just don't think it's particularly intuitive, especially when the > backend was originally intended to be called M680x0, the use of an X to stand > in for different things in very similar situations is confusing. You're right, it's not very intuitive but I think it's not that important in my opinion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D88394/new/ https://reviews.llvm.org/D88394 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
