Budovi planned changes to this revision.
Budovi added inline comments.
================
Comment at: clang/unittests/Format/FormatTest.cpp:19056
+TEST_F(FormatTest, IndentAccessModifiers) {
+ FormatStyle Style = getLLVMStyle();
+ Style.AllowShortEnumsOnASingleLine = false;
----------------
curdeius wrote:
> Please add an assertion that IndentWidth == 2 to make the test easier to
> understand.
The written tests rely on several other "defaults" from the LLVM style. If
somebody changes those defaults these unit tests (along with many others) will
fail. This will also be true if an assertion is present to test this condition.
It would be possible to reassign those values but this goes against how the
rest of the tests are implemented.
But I agree that I could improve the readability by adding brief comments that
point out important settings and the purpose of the included tests.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94661/new/
https://reviews.llvm.org/D94661
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
