hvdijk added a comment. Restoring the old behaviour for LLVM 12 may or may not help the Chrome/Chromium people: if they also regularly build with clang from git, they would need to handle this change anyway. However, if it does help, then it sounds like a good idea to me.
> So we should be working towards removing the `getNumParams() < 2` check in at > least the C++20 case. Right, and the same change has also been accepted for C, has it not? If it has, then also the C2x case. It would be good to align with GCC here. I would imagine that they will want the same thing for GCC you are proposing for clang, but it would be good to make sure. Specifically: it would be good to confirm that there are no objections from GCC's side to supporting `#ifdef __VA_OPT__` as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91913/new/ https://reviews.llvm.org/D91913 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
